[ob] don't skip most of the testsuite... [was: Re: Make remote-sim target always have a thread]

Pedro Alves
2008-07-09T10:53:13Z

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

A Monday 07 July 2008 20:15:18, Daniel Jacobowitz wrote:
> On Thu, Jul 03, 2008 at 07:04:20PM +0100, Pedro Alves wrote:
> > Default results look much better than I was expecting without
> > tweaking the boardfile.

Damn, I keep losing my bonus points.

I looked back as I was going to commit the patches, and noticed
that every test that ran after fullname.exp was being skipped, like
so...

Running ../../../src/gdb/testsuite/gdb.base/fullname.exp ...
gdb compile failed, arm-elf-gcc: gdb_tg.o: No such file or directory
Running ../../../src/gdb/testsuite/gdb.base/funcargs.exp ...
ERROR: ../../../src/gdb/testsuite/gdb.base/funcargs.exp does not exist.
ERROR: ...
...

No wonder I'd got such a clean testsuite run.

The compile failure seems to happen because the gluefile is passed
a relative path to the testsuite/ dir, but this test explicitly
changed dirs:

Executing on host: arm-elf-gcc tmp-fullname.c -g -Wl,-wrap,exit -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort gdb_tg.o -lm -o fullname (timeout = 300)
arm-elf-gcc: gdb_tg.o: No such file or directory
compiler exited with status 1
output is:
arm-elf-gcc: gdb_tg.o: No such file or directory

Fixing this bit will be for a rainy day, but, skipping most of
the testsuite has an obvious fix. See attached, checked in.

I get to keep my bonus, since no one noticed how it must have
been too good to be true to have no other failures :-)

--
Pedro Alves

[-- Attachment #2: fullname.diff --]
[-- Type: text/x-diff, Size: 700 bytes --]

2008-07-09 Pedro Alves <pedro@codesourcery.com>

* gdb.base/fullname.exp: Restore pwd if compiling failed.

---
gdb/testsuite/gdb.base/fullname.exp | 1 +
1 file changed, 1 insertion(+)

Index: src/gdb/testsuite/gdb.base/fullname.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.base/fullname.exp 2008-07-09 00:05:42.000000000 +0100
+++ src/gdb/testsuite/gdb.base/fullname.exp 2008-07-09 00:10:42.000000000 +0100
@@ -104,6 +104,7 @@ if { [gdb_breakpoint ${objdir}/${subdir}
set save_pwd [pwd]
cd ${subdir}
if { [gdb_compile "tmp-${srcfile}" "${testfile}" executable {debug}] != "" } {
+ cd $save_pwd
return -1
}
cd $save_pwd