From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16363 invoked by alias); 9 Jul 2008 10:53:13 -0000 Received: (qmail 16355 invoked by uid 22791); 9 Jul 2008 10:53:13 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jul 2008 10:52:47 +0000 Received: (qmail 26890 invoked from network); 9 Jul 2008 10:52:45 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Jul 2008 10:52:45 -0000 From: Pedro Alves To: Daniel Jacobowitz Subject: [ob] don't skip most of the testsuite... [was: Re: Make remote-sim target always have a thread] Date: Wed, 09 Jul 2008 10:53:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org References: <200807031623.29562.pedro@codesourcery.com> <200807031904.20942.pedro@codesourcery.com> <20080707191518.GE11544@caradoc.them.org> In-Reply-To: <20080707191518.GE11544@caradoc.them.org> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_7hJdIuDBZYmaRr8" Message-Id: <200807091152.43394.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00129.txt.bz2 --Boundary-00=_7hJdIuDBZYmaRr8 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1438 A Monday 07 July 2008 20:15:18, Daniel Jacobowitz wrote: > On Thu, Jul 03, 2008 at 07:04:20PM +0100, Pedro Alves wrote: > > Default results look much better than I was expecting without > > tweaking the boardfile. Damn, I keep losing my bonus points. I looked back as I was going to commit the patches, and noticed that every test that ran after fullname.exp was being skipped, like so... Running ../../../src/gdb/testsuite/gdb.base/fullname.exp ... gdb compile failed, arm-elf-gcc: gdb_tg.o: No such file or directory Running ../../../src/gdb/testsuite/gdb.base/funcargs.exp ... ERROR: ../../../src/gdb/testsuite/gdb.base/funcargs.exp does not exist. ERROR: ... ... No wonder I'd got such a clean testsuite run. The compile failure seems to happen because the gluefile is passed a relative path to the testsuite/ dir, but this test explicitly changed dirs: Executing on host: arm-elf-gcc tmp-fullname.c -g -Wl,-wrap,exit -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort gdb_tg.o -lm -o fullname (timeout = 300) arm-elf-gcc: gdb_tg.o: No such file or directory compiler exited with status 1 output is: arm-elf-gcc: gdb_tg.o: No such file or directory Fixing this bit will be for a rainy day, but, skipping most of the testsuite has an obvious fix. See attached, checked in. I get to keep my bonus, since no one noticed how it must have been too good to be true to have no other failures :-) -- Pedro Alves --Boundary-00=_7hJdIuDBZYmaRr8 Content-Type: text/x-diff; charset="iso-8859-1"; name="fullname.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fullname.diff" Content-length: 700 2008-07-09 Pedro Alves * gdb.base/fullname.exp: Restore pwd if compiling failed. --- gdb/testsuite/gdb.base/fullname.exp | 1 + 1 file changed, 1 insertion(+) Index: src/gdb/testsuite/gdb.base/fullname.exp =================================================================== --- src.orig/gdb/testsuite/gdb.base/fullname.exp 2008-07-09 00:05:42.000000000 +0100 +++ src/gdb/testsuite/gdb.base/fullname.exp 2008-07-09 00:10:42.000000000 +0100 @@ -104,6 +104,7 @@ if { [gdb_breakpoint ${objdir}/${subdir} set save_pwd [pwd] cd ${subdir} if { [gdb_compile "tmp-${srcfile}" "${testfile}" executable {debug}] != "" } { + cd $save_pwd return -1 } cd $save_pwd --Boundary-00=_7hJdIuDBZYmaRr8--