From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4941 invoked by alias); 7 Jul 2008 19:06:03 -0000 Received: (qmail 4933 invoked by uid 22791); 7 Jul 2008 19:06:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 Jul 2008 19:05:42 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 825D498415; Mon, 7 Jul 2008 19:05:40 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 62F719805C; Mon, 7 Jul 2008 19:05:40 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KFw1r-00035q-Qc; Mon, 07 Jul 2008 15:05:39 -0400 Date: Mon, 07 Jul 2008 19:06:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org, Vladimir Prus Subject: Re: functions that delete breakpoints should not insert bp locations (was: Fix execl.exp sporadic failures) Message-ID: <20080707190539.GB11544@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org, Vladimir Prus References: <200807030226.54896.pedro@codesourcery.com> <200807031145.54289.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807031145.54289.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00089.txt.bz2 On Thu, Jul 03, 2008 at 11:45:53AM +0100, Pedro Alves wrote: > 2008-07-03 Pedro Alves > > * breakpoint.c (update_global_location_list): Add boolean > "should_insert" argument. Only insert locations if caller told it > too. > (update_global_location_list_nothrow): Add boolean "should_insert" > argument. Pass it to update_global_location_list. > (insert_breakpoints, create_longjmp_breakpoint) > (create_overlay_event_breakpoint, enable_overlay_breakpoints) > (create_thread_event_breakpoint, create_solib_event_breakpoint) > (create_fork_vfork_event_catchpoint, create_exec_event_catchpoint) > (enable_watchpoints_after_interactive_call_stop) > (set_momentary_breakpoint, create_breakpoints) > (break_command_really, watch_command_1) > (create_ada_exception_breakpoint, update_breakpoint_locations) > (do_enable_breakpoint, enable_command): Pass true to > update_global_location_list. > (bpstat_stop_status, disable_overlay_breakpoints) > (disable_watchpoints_before_interactive_call_start) > (delete_breakpoint, disable_breakpoint, disable_command): Pass > false to update_global_location_list. > (update_breakpoints_after_exec): Don't temporarily disable > always-inserted mode. Thanks, this is OK. -- Daniel Jacobowitz CodeSourcery