From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22988 invoked by alias); 3 Jul 2008 16:48:07 -0000 Received: (qmail 22977 invoked by uid 22791); 3 Jul 2008 16:48:06 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 03 Jul 2008 16:47:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3965C2A9753; Thu, 3 Jul 2008 12:47:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TGQ0cQq3GJ-Z; Thu, 3 Jul 2008 12:47:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E57182A96E1; Thu, 3 Jul 2008 12:47:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B5399E7ACD; Thu, 3 Jul 2008 12:47:44 -0400 (EDT) Date: Thu, 03 Jul 2008 16:48:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Get rid of ATTACH_NO_WAIT Message-ID: <20080703164744.GA19465@adacore.com> References: <200806280018.59156.pedro@codesourcery.com> <200806280025.40155.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806280025.40155.pedro@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00038.txt.bz2 Hi Pedro, > 2008-06-28 Pedro Alves > > * config/i386/nm-cygwin.h (ATTACH_NO_WAIT): Delete. > * config/i386/nm-i386gnu.h (ATTACH_NO_WAIT): Delete. > > * target.h (struct target_ops): Add to_attach_no_wait member. > (target_attach_no_wait): New. > * target.c (update_current_target): Inherit to_attach_no_wait. > > * infcmd.c: Replace ATTACH_NO_WAIT compile time check by > target_attach_no_wait runtime check. > > * gnu-nat.c (init_gnu_ops): Set to_attach_no_wait in gnu_ops. > * win32-nat.c (init_win32_ops): Set to_attach_no_wait in > win32_ops. I will be glad to see this macro go, and overall the patch looks good to me. One thing I had to think about a little was whether this property should be inherited or not (see target.c:update_current_target()). I'm still not sure, but I think it should. Imagine that we had a thread stratum on win32. Wouldn't you lose the attach_no_wait property when this thread stratum got pushed on the target? Until we find a target where the process and thread strata need a different setting, I think it's safer for now to make it inheritable. What do you think? -- Joel