A Thursday 03 July 2008 09:48:13, Vladimir Prus wrote:
> Pedro Alves wrote:
> > static void
> > -update_global_location_list (void)
> > +update_global_location_list (int inserting)
>
> There's no comment for the new parameter. Also, the parameter tells
> the function to do, or not do something, so "-ing" sounds awkward.
> How about 'should_insert' or 'suppress_insert'?

You're quite right.  I changed it to should_inserted, to avoid
going through all callers and reverse the logic.  And added a
comment similar to what you suggested.

Thanks!

-- 
Pedro Alves