From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6384 invoked by alias); 1 Jul 2008 22:03:11 -0000 Received: (qmail 6364 invoked by uid 22791); 1 Jul 2008 22:03:09 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 Jul 2008 22:02:42 +0000 Received: (qmail 5737 invoked from network); 1 Jul 2008 22:02:39 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jul 2008 22:02:39 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] use filename_completer for add_setshow_optional_filename_cmd Date: Tue, 01 Jul 2008 22:03:00 -0000 User-Agent: KMail/1.9.9 Cc: "Pierre Muller" References: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr> In-Reply-To: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807012302.38644.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00007.txt.bz2 (following the spirit of speaking up if you spent the time looking at the patch) A Tuesday 01 July 2008 22:37:42, Pierre Muller wrote: > I discovered that > set debug-file-directory does not use filename_completer. > > This is because add_setshow_optional_filename_cmd > does not set the set completer to filename completer, > contrary to add_setshow_filename_cmd. > > Is there any reason for this? > Or is it just a bug? IMHO, it's just a feature miss. > The following small patch fixes this > by setting the set part completer to filename_completer > for add_setshow_optional_filename_cmd > exactly as is done in add_setshow_filename_cmd. > > There are currently only three adffected commands: > > "set debug-file-directory" > "set args" > "set solib-search-path" > > Only the second one might be questionable, > but I also find that it is reasonable to have filename > completion for "set args" as this is now done on > most shells. > IMHO, it does make more sense to have a filename completer in "set args," than a default symbol completer. You're normally not very interested in passing symbol names as arguments to your program. > Is this OK to commit? FWIW, looks good to me. -- Pedro Alves