From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1092 invoked by alias); 1 Jul 2008 00:28:48 -0000 Received: (qmail 1081 invoked by uid 22791); 1 Jul 2008 00:28:47 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 Jul 2008 00:28:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 045852A967B; Mon, 30 Jun 2008 20:28:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Nq80WhlY56ET; Mon, 30 Jun 2008 20:28:10 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9CA4A2A9685; Mon, 30 Jun 2008 20:28:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1879AE7ACD; Mon, 30 Jun 2008 20:28:08 -0400 (EDT) Date: Tue, 01 Jul 2008 00:28:00 -0000 From: Joel Brobecker To: Bruno Haible Cc: Daniel Jacobowitz , bug-gnulib@gnu.org, gdb-patches@sourceware.org Subject: Re: [RFC] Use gnulib's stdint.h. Message-ID: <20080701002808.GA1390@adacore.com> References: <20080605184041.GA25085@caradoc.them.org> <20080627185907.GA11664@adacore.com> <20080627191314.GA19538@caradoc.them.org> <200806280259.26427.bruno@clisp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806280259.26427.bruno@clisp.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00000.txt.bz2 Hi Bruno, > > > 2. ctype/safe-ctype conflict. For instance, cp-support.c includes > > > safe-ctype.h. But at the same time, we previously included > > > defs.h, which itself includes gnulib/stdint.h, which includes > > > which includes . > > > > > Problem #2 is a lot more problematic, however. I might argue that > > > this is a actually bug inside gnulib and that gnulib/stdint.h > > > should be generated in a way that avoids including other standard > > > header files. > > No. gnulib makes no guarantee that particular headers or symbols are > not defined. I wasn't really suggesting that gnulib should make a general guaranty, but if the wchar.h include could easily be avoided, then it would have made GDB's life a little easier. It was worth asking :) > 3. In those places where gnulib could control these extra #includes, > the price would be sets of #ifdefs that would be too clumsy to be > maintainable. I see your point. > The bug is in safe-ctype.h: > > #ifdef isalpha > #error "safe-ctype.h and ctype.h may not be used simultaneously" > #endif > > Actually I don't see the reason for this #error: safe-ctype.h defines only > uppercase-named macros, and defines only lowercase-named or > underscore-prefixed macros. I will see with the GCC maintainers what they think. Maybe the check made better sense at one point, but no longer makes sense today. I checked the public history of that file and version 1 of that file (dated circa 2000) already defines the macros in uppercase and has the isalpha macro check. -- Joel