From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6967 invoked by alias); 29 Jun 2008 05:38:57 -0000 Received: (qmail 6776 invoked by uid 22791); 29 Jun 2008 05:38:56 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 29 Jun 2008 05:38:08 +0000 Received: (qmail 15513 invoked from network); 29 Jun 2008 05:38:06 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Jun 2008 05:38:06 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [MI non-stop 01/11] Report thread state in -thread-info output. Date: Sun, 29 Jun 2008 06:03:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sources.redhat.com References: <200806282034.58776.vladimir@codesourcery.com> <18534.55895.723858.908890@kahikatea.snap.net.nz> In-Reply-To: <18534.55895.723858.908890@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806290938.09325.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00572.txt.bz2 On Sunday 29 June 2008 04:41:59 Nick Roberts wrote: > > This patch adds the 'state' field to the output of -thread-info. Since > > it only changes MI behaviour, I guess I don't need it approved, and > > it seems fairly trivial so I doubt we'll have much discussion of this one :-) > > But this isn't a self contained patch, it seems to need changes in the last > of the series [MI non-stop 10/11]. MI non-stop 10/11 is "Skip varobj in running threads.". I don't think there's any dependency on that. Of course, as I wrote in the overview, this patch needs Pedro's patches. > ISTR that Pedro cascaded his patches so > that it was possible to look at one change after the other. > > > - Volodya > > > > * thread.c (print_thread_info): Add new field "state". > > --- > > gdb/thread.c | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/gdb/thread.c b/gdb/thread.c > > index d0e17c5..4e172d8 100644 > > --- a/gdb/thread.c > > +++ b/gdb/thread.c > > @@ -806,6 +806,16 @@ print_thread_info (struct ui_out *uiout, int requested_thread) > > LOCATION); > > } > > > > + if (ui_out_is_mi_like_p (uiout)) > > + { > > + char *state = "stopped"; > > + if (tp->state_ == THREAD_EXITED) > ^^^^^^^^^^ ^^^^^^^^^^^^^ > Not defined here. This field is introduced by Pedro's patches. - Volodya