From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 342 invoked by alias); 28 Jun 2008 11:34:50 -0000 Received: (qmail 334 invoked by uid 22791); 28 Jun 2008 11:34:49 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 28 Jun 2008 11:34:17 +0000 Received: (qmail 8345 invoked from network); 28 Jun 2008 11:34:15 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Jun 2008 11:34:15 -0000 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Re: [MI] report pass for resuming commands Date: Sat, 28 Jun 2008 11:58:00 -0000 User-Agent: KMail/1.9.9 References: <200806281416.04427.vladimir@codesourcery.com> In-Reply-To: <200806281416.04427.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_1GiZIMmiJKFB9yB" Message-Id: <200806281534.13445.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00535.txt.bz2 --Boundary-00=_1GiZIMmiJKFB9yB Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 349 On Saturday 28 June 2008 14:16:04 Vladimir Prus wrote: > > I've noticed that the test helper routine for sending resuming commands > fails to report passes. Fixes by attached commit. Doh! This patch was the most obvious patch in the world, so I've neglected to run the tests -- which, of course, failed. Reverted thusly, with comment. - Volodya --Boundary-00=_1GiZIMmiJKFB9yB Content-Type: text/x-diff; charset="iso-8859-15"; name="commit.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="commit.diff" Content-length: 1743 Index: gdb/testsuite/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.1669 diff -u -p -r1.1669 ChangeLog --- gdb/testsuite/ChangeLog 28 Jun 2008 11:15:34 -0000 1.1669 +++ gdb/testsuite/ChangeLog 28 Jun 2008 11:30:33 -0000 @@ -1,3 +1,8 @@ +2008-06-28 Vladimir Prus + + * lib/mi-support.exp (mi_send_resuming_command_raw): Revert + previous commit. Add a comment. + 2008-06-28 Pedro Alves * gdb.base/sigchld.c, gdb.base/sigchld.exp: New test. Index: gdb/testsuite/lib/mi-support.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v retrieving revision 1.64 diff -u -p -r1.64 mi-support.exp --- gdb/testsuite/lib/mi-support.exp 28 Jun 2008 10:14:34 -0000 1.64 +++ gdb/testsuite/lib/mi-support.exp 28 Jun 2008 11:30:33 -0000 @@ -1398,7 +1398,15 @@ proc mi_send_resuming_command_raw {comma send_gdb "$command\n" gdb_expect { -re "\\^running\r\n\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" { - pass "$test" + # Note that lack of 'pass' call here -- this works around limitation + # in DejaGNU xfail mechanism. mi-until.exp has this: + # + # setup_kfail gdb/2104 "*-*-*" + # mi_execute_to ... + # + # and mi_execute_to uses mi_send_resuming_command. If we use 'pass' here, + # it will reset kfail, so when the actual test fails, it will be flagged + # as real failure. } -re ".*${mi_gdb_prompt}" { fail "$test (failed to resume)" --Boundary-00=_1GiZIMmiJKFB9yB--