From: Daniel Jacobowitz <drow@false.org>
To: Jonathan Larmour <jifl@eCosCentric.com>
Cc: gdb-patches@sourceware.org
Subject: Re: remote.c Z0 packet detection robustness
Date: Fri, 27 Jun 2008 18:59:00 -0000 [thread overview]
Message-ID: <20080627182222.GA11364@caradoc.them.org> (raw)
In-Reply-To: <48652EB5.2010008@eCosCentric.com>
On Fri, Jun 27, 2008 at 07:17:25PM +0100, Jonathan Larmour wrote:
> Daniel Jacobowitz wrote:
> > On Fri, Jun 27, 2008 at 04:55:37PM +0100, Jonathan Larmour wrote:
> >> 2008-06-27 Jonathan Larmour <jifl@eCosCentric.com>
> >>
> >> * remote.c (remote_insert_breakpoint): Ensure that if Z0
> >> unsupported and we fall back to memory_insert_breakpoint, we
> >> use the unmodified requested address.
> >
> > Thanks for the clear explanation. This is almost OK - but you need to
> > update bp_tgt if Z0 succeeds. Otherwise we may remove the breakpoint
> > incorrectly.
>
> Is this better?
Yes, this version is fine to commit. Thanks.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-06-27 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 16:25 Jonathan Larmour
2008-06-27 16:42 ` Daniel Jacobowitz
2008-06-27 18:22 ` Jonathan Larmour
2008-06-27 18:59 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627182222.GA11364@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jifl@eCosCentric.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox