Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jonathan Larmour <jifl@eCosCentric.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Avoid potential crashes with --gc-sections and low addresses
Date: Fri, 27 Jun 2008 17:14:00 -0000	[thread overview]
Message-ID: <20080627164106.GB4724@caradoc.them.org> (raw)
In-Reply-To: <4865094E.2000004@eCosCentric.com>

On Fri, Jun 27, 2008 at 04:37:50PM +0100, Jonathan Larmour wrote:
> --- gdb/dwarf2-frame.c~	2008-05-04 00:24:17.000000000 +0100
> +++ gdb/dwarf2-frame.c	2008-06-20 17:06:04.000000000 +0100
> @@ -1795,7 +1795,8 @@ decode_frame_entry_1 (struct comp_unit *
>  
>        fde->eh_frame_p = eh_frame_p;
>  
> -      add_fde (unit, fde);
> +      if (fde->initial_location)
> +          add_fde (unit, fde);
>      }
>  
>    return end;

This won't work if there is code actually at zero.  Take a look at the
.debug_info reader to see how we handled this case for symbolic debug info.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-06-27 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 15:56 Jonathan Larmour
2008-06-27 16:01 ` Jonathan Larmour
2008-06-27 17:14   ` Daniel Jacobowitz [this message]
2008-06-27 18:31     ` Jonathan Larmour
2008-06-27 19:13       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080627164106.GB4724@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jifl@eCosCentric.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox