Re: make the remote target store thread ids in ptid_t.tid

Daniel Jacobowitz
2008-06-26T02:22:58Z

On Wed, Jun 25, 2008 at 11:51:59PM +0100, Pedro Alves wrote:
> I've tested this extensivelly by talking to a native gdbserver,
> and native gdbserver with vCont disabled, and then also with a
> gdbserver with vCont and all thread related packets and fields
> disabled, to simulate old stubs and stubs that don't support
> threads at all.

These sound useful for testing. Any interest in making them command
line options for gdbserver?

> 2008-06-25 Pedro Alves <pedro@codesourcery.com>
>
> Use ptid_t.tid to store thread ids instead of ptid_t.pid.
>
> * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): New
> globals.
> (general_thread, continue_thread): Change type to ptid_t.
> (record_currthread): Take a ptid_t parameter instead of an
> integer.
> (MAGIC_NULL_PID): Delete.
> (set_thread): Take a ptid_t parameter and adjust.
> (set_general_thread, set_continue_thread): New.
> (remote_thread_alive, remote_newthread_step)
> (remote_current_thread, remote_find_new_threads)
> (remote_threads_info, remote_start_remote, remote_vcont_resume)
> (remote_resume_1, remote_wait, extended_remote_create_inferior_1)
> (threadalive_test, remote_pid_to_str)
> (remote_get_thread_local_address): Adjust.
> (_initialize_remote): Initialize magic_null_ptid, not_sent_ptid
> and any_thread_ptid.

Looks OK to me.

--
Daniel Jacobowitz
CodeSourcery