From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28842 invoked by alias); 25 Jun 2008 19:12:23 -0000 Received: (qmail 28827 invoked by uid 22791); 25 Jun 2008 19:12:21 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 19:12:02 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5BF279835A; Wed, 25 Jun 2008 19:12:00 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 38D659810F; Wed, 25 Jun 2008 19:12:00 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KBaPP-0007PG-KJ; Wed, 25 Jun 2008 15:11:59 -0400 Date: Wed, 25 Jun 2008 19:18:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [non-stop] 05/10 Refactor a bit infrun.c Message-ID: <20080625191159.GC25575@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200806152204.44095.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806152204.44095.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00447.txt.bz2 On Sun, Jun 15, 2008 at 10:04:43PM +0100, Pedro Alves wrote: > 2008-06-15 Pedro Alves > > * infrun.c (currently_stepping): Take a struct > thread_stepping_state instead of an execution_control_state. > (struct thread_stepping_state): New, split from > execution_control_state. > (gtss, tss): New globals. > (proceed): Clear the stepping state, set previous_inferior_ptid > and clear infwait state. > (init_wait_for_inferior): Clear the stepping state, > previous_inferior_ptid and infwait state. > (waiton_ptid, infwait_state): New, split from > execution_control_state. > (struct execution_control_state): Members that persist through > events moved out to either struct thred_stepping_state or made > global. Deleted unneeded wp, saved_inferior_ptid, tmpstatus. > (wait_for_inferior, fetch_inferior_event): Use local > execution_control_state. Update to execution_control_state split. > (init_execution_control_state): Adjust. > (init_thread_stepping_state): New, extracted from > init_execution_control_state. > (context_switch): Take a ptid instead of an > execution_control_state. > (context_switch_to): Adjust. > (adjust_pc_after_break): Adjust. > (init_infwait_state): New. > (handle_inferior_event): Adjust. OK. > @@ -1491,13 +1510,16 @@ wait_for_inferior (int treat_exec_as_sig > void > fetch_inferior_event (void *client_data) > { > + struct execution_control_state ecss = ecss; Please don't use this - IIRC it's a GCC extension to shut up uninitialized variable warnings. If there are warnings without the initializer, just memset it. -- Daniel Jacobowitz CodeSourcery