From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5490 invoked by alias); 25 Jun 2008 13:35:20 -0000 Received: (qmail 5479 invoked by uid 22791); 25 Jun 2008 13:35:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 13:35:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D56C39835A; Wed, 25 Jun 2008 13:34:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9E3579810F; Wed, 25 Jun 2008 13:34:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KBV9F-0002AG-UB; Wed, 25 Jun 2008 09:34:57 -0400 Date: Wed, 25 Jun 2008 13:43:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Michael Snyder , gdb-patches@sourceware.org Subject: Re: [RFA] set/show enable-software-singlestep Message-ID: <20080625133457.GA8020@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Michael Snyder , gdb-patches@sourceware.org References: <1214331534.3601.1211.camel@localhost.localdomain> <20080624182933.GA12195@caradoc.them.org> <1214335528.3601.1216.camel@localhost.localdomain> <20080625125424.GC3700@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080625125424.GC3700@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00430.txt.bz2 On Wed, Jun 25, 2008 at 08:54:24AM -0400, Joel Brobecker wrote: > Hi Michael, > > > 2008-06-23 Michael Snyder > > > > * infrun.c (can_use_sw_ss): New mode variable. > > (show_can_use_sw_ss): New setshow helper function. > > (resume): Check for can-use-software-singlestep. > > (_initialize_infrun): Add set/show command for > > can-use-software-singlestep. > > As discussed previously on gdb@, I think this is a useful feature > even outside of reverse debugging. Regarding Pedro's question > about making this feature transparent, that would be tough for > the example I gave, which is Tru64 - we want to be able to use > s/w single-step only on programs that use threads. To make it automatic, > we'd have to reliably detect that a program uses threads. Perhaps > this is doable, but having the option is an easy first step. Later > on, we can always extend the option to a tri-state with an "auto" > setting if it helps... I think it should already be auto. can-use-software-singlestep is unintuitive - either do use it, don't use it, or use GDB's best judgement. And if the user selects to use it and it isn't supported, that's an error when we next want to singlestep. WDYT? > The code itself looks good, but I'm not so sure about accessing this > feature through a "maint" command. Since in my eyes it's a feature, > I'd personally be inclined to make it accessible through "set/show > can-use-software-singlestep". It is an obscure feature, however, so > I'm not really that concerned about it. How about we wait for another > week to see if we have any other comment; if not, then just commit > as is. I agree with Joel; if we want to have the user knob at all, no gain in hiding it. -- Daniel Jacobowitz CodeSourcery