From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56788-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3084 invoked by alias); 24 Jun 2008 01:15:19 -0000
Received: (qmail 3067 invoked by uid 22791); 24 Jun 2008 01:15:18 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-71-248-179-123.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (71.248.179.123)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jun 2008 01:15:01 +0000
Received: by ednor.cgf.cx (Postfix, from userid 201) 	id 619A9608DFE; Mon, 23 Jun 2008 21:14:56 -0400 (EDT)
Date: Tue, 24 Jun 2008 06:33:00 -0000
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>, 	'Pedro Alves' <pedro@codesourcery.com>, 	Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [RFC] win32-nat.c 'set new-console' and interruption
Message-ID: <20080624011456.GB13397@ednor.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org, 	Joel Brobecker <brobecker@adacore.com>, 	'Pedro Alves' <pedro@codesourcery.com>, 	Pierre Muller <muller@ics.u-strasbg.fr>
References: <000001c8d330$0c6b51f0$2541f5d0$@u-strasbg.fr> <200806231541.26276.pedro@codesourcery.com> <20080623173620.GA10962@ednor.casa.cgf.cx> <200806231922.10798.pedro@codesourcery.com> <000301c8d566$bb831690$328943b0$@u-strasbg.fr> <20080623195153.GA3746@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080623195153.GA3746@adacore.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-06/txt/msg00402.txt.bz2

On Mon, Jun 23, 2008 at 03:51:53PM -0400, Joel Brobecker wrote:
>> I find it cleaner with signal SIGINT, but it's true that the other
>> option is simpler and not that different!
>
>I think most people would expect to see SIGINT. Also, seeing a SIGINT
>would make it consistent with what the user would see if the console
>was shared.
>
>>   Christopher, should I just remove the ctrl_break_sent variable and
>>   let GDB use SIGTRAP signal?
>
>So, I would personally prefered if we kept the SIGTRAP to SIGINT
>translation... Just my 2 cents.

I think that makes 4 cents.  A SIGTRAP would be confusing.

I haven't looked at the patch yet, however.

cgf