Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Robustify mi-simplerun.
Date: Fri, 13 Jun 2008 21:08:00 -0000	[thread overview]
Message-ID: <200806140010.05202.vladimir@codesourcery.com> (raw)
In-Reply-To: <20080613200035.GA31920@caradoc.them.org>

On Saturday 14 June 2008 00:00:35 Daniel Jacobowitz wrote:
> On Fri, Jun 13, 2008 at 11:55:42PM +0400, Vladimir Prus wrote:
> > The program been run by this testcase produces output.  Since GDB prints
> > the *running notification, and the prompt, after actually resuming the program,
> > there's a race condition -- the program may produce the output before gdb prints
> > the prompt, which breaks the test.  This patch add artificial delay to the 
> > program to make sure gdb print the prompt first.
> 
> Is the output necessary for any test?  If not, can we just remove it?
> Sleep is bad.  Someone'll run the testsuite on a machine with load
> (e.g. our nightly tester) and it'll fail again.

I cannot find any evidence that the output is directly tested for. There are
some tests that rely on the presence of the code statements that produce
this output, so just removing those prints will be more work.

Do you actually think high load will break this? Essentially, we only need
gdb to grab a single slice of processor time before the debugged program gets to
printing, and I'd expect it will, during that second.

- Volodya


  reply	other threads:[~2008-06-13 20:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 20:10 Vladimir Prus
2008-06-13 20:13 ` Daniel Jacobowitz
2008-06-13 21:08   ` Vladimir Prus [this message]
2008-06-13 21:13     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806140010.05202.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox