From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56626-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22755 invoked by alias); 13 Jun 2008 14:32:54 -0000
Received: (qmail 22741 invoked by uid 22791); 13 Jun 2008 14:32:52 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Jun 2008 14:32:35 +0000
Received: (qmail 8656 invoked from network); 13 Jun 2008 14:32:33 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 13 Jun 2008 14:32:33 -0000
From: Pedro Alves <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] win32-nat.c: Add dll names if debugevents is on
Date: Fri, 13 Jun 2008 15:35:00 -0000
User-Agent: KMail/1.9.9
Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>
References: <000001c8cd57$c9cf3d30$5d6db790$@u-strasbg.fr>
In-Reply-To: <000001c8cd57$c9cf3d30$5d6db790$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806131532.22427.pedro_alves@portugalmail.pt>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-06/txt/msg00240.txt.bz2

Thanks, I've wanted this before too.

A Friday 13 June 2008 14:17:11, Pierre Muller wrote:

> $ cvs diff -up gdb/win32-nat.c
> Index: gdb/win32-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/win32-nat.c,v
> retrieving revision 1.152
> diff -u -p -r1.152 win32-nat.c
> --- gdb/win32-nat.c     20 May 2008 18:36:36 -0000      1.152
> +++ gdb/win32-nat.c     13 Jun 2008 11:27:18 -0000
> @@ -744,6 +744,7 @@ handle_load_dll (void *dummy)
>    if (!dll_name)
>      return 1;
>
> +  DEBUG_EVENTS (("gdb: Loading dll \"%s\".\n",dll_name));
>    solib_end->next = win32_make_so (dll_name, (DWORD) event->lpBaseOfDll);

While you're at it, would it be useful to also include the dll
load base in the output?

>    solib_end = solib_end->next;
>
> @@ -771,6 +772,9 @@ handle_unload_dll (void *dummy)
>         so->next = sodel->next;
>         if (!so->next)
>           solib_end = so;
> +       if (sodel->so_original_name)
> +         DEBUG_EVENTS (("gdb: removing dll \"%s\".\n",

Small nit, wouldn't "gdb: Unloading dll" be clearer (and mirror
the other message) ?  And perhaps output "<unknown name>", if
there's no so_original_name to print?  Can that happen?  I
can't remember off-hand.

-- 
Pedro Alves