From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32588 invoked by alias); 11 Jun 2008 00:04:15 -0000 Received: (qmail 32579 invoked by uid 22791); 11 Jun 2008 00:04:13 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Jun 2008 00:03:42 +0000 Received: (qmail 24831 invoked from network); 11 Jun 2008 00:03:22 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Jun 2008 00:03:22 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Remove undocumented remote procotol extension Date: Wed, 11 Jun 2008 00:24:00 -0000 User-Agent: KMail/1.9.9 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_VZxTIjpnMtBCKTk" Message-Id: <200806110103.33301.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00212.txt.bz2 --Boundary-00=_VZxTIjpnMtBCKTk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 261 Hi, Following up on, [remote] Where is S AA p PID currently specified? http://sourceware.org/ml/gdb/2008-06/msg00081.html Here is the patch that removes the undocumented extension. Is this NEWS worthy? If so, NEWS change included. OK ? -- Pedro Alves --Boundary-00=_VZxTIjpnMtBCKTk Content-Type: text/x-diff; charset="utf-8"; name="cisco.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cisco.diff" Content-length: 1547 2008-06-11 Pedro Alves * NEW: Mention support removal for undocumented S AA p PID stop reply packet. * remote.c (remote_wait): Remove undocumented S AA p PID support. --- gdb/NEWS | 6 ++++++ gdb/remote.c | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) Index: src/gdb/NEWS =================================================================== --- src.orig/gdb/NEWS 2008-06-11 00:47:26.000000000 +0100 +++ src/gdb/NEWS 2008-06-11 00:52:20.000000000 +0100 @@ -19,6 +19,12 @@ completions will be "f1" and "f2". qSearch:memory: Search memory for a sequence of bytes. +* Removed remote protocol undocumented extension + + An undocumented extension to the remote protocol's `S' stop reply + packet that permited the stub to pass a process id was removed. + Remote servers shall use the `T' stop reply packet instead. + * The "disassemble" command now supports an optional /m modifier to print mixed source+assembly. Index: src/gdb/remote.c =================================================================== --- src.orig/gdb/remote.c 2008-06-11 00:46:09.000000000 +0100 +++ src/gdb/remote.c 2008-06-11 00:46:52.000000000 +0100 @@ -3523,12 +3523,6 @@ Packet: '%s'\n"), status->value.sig = (enum target_signal) (((fromhex (buf[1])) << 4) + (fromhex (buf[2]))); } - - if (buf[3] == 'p') - { - thread_num = strtol ((const char *) &buf[4], NULL, 16); - record_currthread (thread_num); - } goto got_status; case 'W': /* Target exited. */ { --Boundary-00=_VZxTIjpnMtBCKTk--