Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Joel Brobecker <brobecker@adacore.com>,  gdb-patches@sources.redhat.com
Subject: Re: [RFA] Use observers to report stop events.
Date: Tue, 10 Jun 2008 13:25:00 -0000	[thread overview]
Message-ID: <200806101657.30671.vladimir@codesourcery.com> (raw)
In-Reply-To: <20080610124313.GA5279@caradoc.them.org>

On Tuesday 10 June 2008 16:43:13 Daniel Jacobowitz wrote:
> On Tue, Jun 10, 2008 at 01:36:23PM +0400, Vladimir Prus wrote:
> > If proceed throws, before calling normal_stop, we'll get back to event loop,
> > and run cleanup. We won't call the observer. It's an issue if we've printed
> > "*running" and thrown after after. However, it's the issue we have now, as
> > well -- we print ^running even before calling proceed, and if something later
> > throws, we'll never print *stopped. Possible solutions are:
> > - Require that frontend refresh thread state on ^error
> > - Emit *stopped if exception is thrown (this requires checking that the
> > target is actually stopped, if exception is thrown).
> 
> Or just don't print *running until we're actually running.  

We emit *running only when we're actually running -- after resuming
target. The danger, as I understand it, is that if exception is thrown
after we've resumed target, but before normal_stop called an observer,
we'll have *running not paired with *stopped, so the frontend will think
the target is still running.

- Volodya


  reply	other threads:[~2008-06-10 12:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 20:05 Vladimir Prus
2008-04-24 13:47 ` Vladimir Prus
2008-04-29  8:03 ` Joel Brobecker
2008-04-29 18:30   ` Vladimir Prus
2008-05-01 19:58     ` Daniel Jacobowitz
2008-05-01 20:11       ` Pedro Alves
2008-05-01 20:17         ` Vladimir Prus
2008-05-04  9:05       ` Vladimir Prus
2008-05-28 18:30         ` Vladimir Prus
2008-06-05 15:41         ` Daniel Jacobowitz
2008-06-10 11:58           ` Vladimir Prus
2008-06-10 13:21             ` Daniel Jacobowitz
2008-06-10 13:25               ` Vladimir Prus [this message]
2008-06-10 13:51                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806101657.30671.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox