From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14468 invoked by alias); 10 Jun 2008 12:43:36 -0000 Received: (qmail 14450 invoked by uid 22791); 10 Jun 2008 12:43:36 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jun 2008 12:43:16 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 06BF09840C; Tue, 10 Jun 2008 12:43:15 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C4D5E9810F; Tue, 10 Jun 2008 12:43:14 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K63Bx-0001T0-N5; Tue, 10 Jun 2008 08:43:13 -0400 Date: Tue, 10 Jun 2008 13:21:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA] Use observers to report stop events. Message-ID: <20080610124313.GA5279@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Joel Brobecker , gdb-patches@sources.redhat.com References: <200804112145.58456.vladimir@codesourcery.com> <200805041225.54416.vladimir@codesourcery.com> <20080605154111.GA29085@caradoc.them.org> <200806101336.24223.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806101336.24223.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00200.txt.bz2 On Tue, Jun 10, 2008 at 01:36:23PM +0400, Vladimir Prus wrote: > If proceed throws, before calling normal_stop, we'll get back to event loop, > and run cleanup. We won't call the observer. It's an issue if we've printed > "*running" and thrown after after. However, it's the issue we have now, as > well -- we print ^running even before calling proceed, and if something later > throws, we'll never print *stopped. Possible solutions are: > - Require that frontend refresh thread state on ^error > - Emit *stopped if exception is thrown (this requires checking that the > target is actually stopped, if exception is thrown). Or just don't print *running until we're actually running. For now it's fine as you have it. Thanks. -- Daniel Jacobowitz CodeSourcery