Re: [PATCH] Another annotation for threads

Daniel Jacobowitz
2008-06-05T19:30:40Z

On Wed, May 21, 2008 at 02:53:54PM +1200, Nick Roberts wrote:
>
> This is a patch for another annotation, this time for thread changes. It
> follows an earlier patch (not committed) for notifying thread changes in MI
> using observers. In that patch thread changes were notified in two places:
> normal_stop in infrun.c and do_captured_thread_select in thread.c. Here
> normal_stop is used but the second call has been moved to thread_command so
> that temporary thread changes in commands like "info thread", "-var-update" etc
> aren't reported.
>
> In the doc patch, I've used @r{, annotation} with findex but I don't know what
> all this does as annotate.texinfo doesn't appear to have a function index.
>
> If this patch is OK, I will submit a similar one for MI using an observer.

It's quite likely that I've gotten turned around in all the discussion
while I was away, and you've already answered this. But here's my
question anyway: if there's going to be an observer to do this in MI,
why shouldn't annotate.c use the same observer to call
annotate_thread_changed?

--
Daniel Jacobowitz
CodeSourcery