Re: [PATCH] Another annotation for threads

Nick Roberts
2008-06-06T03:00:33Z

> 2008-05-21  Nick Roberts  <nickrob@snap.net.nz>
>
>         * annotate.c (annotate_thread_changed): New function.
>         * thread.c (thread_command) : Use it.
>         * infrun.c (normal_stop): Use it.
>
> This broke the build, as the annotate_thread_changed function isn't
> declared anywhere.
>
> I checked the attached in, as obvious.

Yes, sorry. I have several changes in that directory and I missed that file in
the patch that I posted.

> Out of curiosity, was there a reason you committed every file as
> individual commits? It's customary to do a patch per commit
> (not that is matter that much with CVS, but still nice to be
> able to correlate by date, and to look at gdb-cvs).

It's the way VC works in Emacs. I could use pcl-cvs but I've not really got
used to it. Each file is committed individually but the changeset is given
in the ChangeLog, although multiple ChangeLogs are needed across directories
as is the case here.

It would be nice to move GDB to a modern version control system where patches
are really committed as changesets. Systems such as GIT allow local branches
also which would help to keep local changes separate too.

It's also easier to try multiple file patches out from the mailing list and
revert them, etc, etc.

For now, anyway, I'll try to use pcl-cvs to keep the traffic down on gdb-cvs.

--
Nick http://www.inet.net.nz/~nickrob