Re: [PATCH] Another annotation for threads

Pedro Alves
2008-06-06T02:39:08Z

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

A Friday 06 June 2008 01:49:12, Nick Roberts wrote:
> Daniel Jacobowitz writes:

> ... but the patch is OK.
>
> Committed. Thanks.

2008-05-21  Nick Roberts  <nickrob@snap.net.nz>

* annotate.c (annotate_thread_changed): New function.
* thread.c (thread_command) : Use it.
* infrun.c (normal_stop): Use it.

This broke the build, as the annotate_thread_changed function isn't
declared anywhere.

I checked the attached in, as obvious.

Out of curiosity, was there a reason you committed every file as
individual commits? It's customary to do a patch per commit
(not that is matter that much with CVS, but still nice to be
able to correlate by date, and to look at gdb-cvs).

--
Pedro Alves

[-- Attachment #2: annotate.diff --]
[-- Type: text/x-diff, Size: 591 bytes --]

2008-06-06 Pedro Alves <pedro@codesourcery.com>

* annotate.h (annotate_thread_changed): Declare.

---
gdb/annotate.h | 1 +
1 file changed, 1 insertion(+)

Index: src/gdb/annotate.h
===================================================================
--- src.orig/gdb/annotate.h 2008-06-06 03:27:03.000000000 +0100
+++ src/gdb/annotate.h 2008-06-06 03:27:44.000000000 +0100
@@ -44,6 +44,7 @@ extern void annotate_breakpoints_table_e

extern void annotate_frames_invalid (void);
extern void annotate_new_thread (void);
+extern void annotate_thread_changed (void);

struct type;