From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31324 invoked by alias); 5 Jun 2008 19:30:40 -0000 Received: (qmail 31311 invoked by uid 22791); 5 Jun 2008 19:30:40 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 19:30:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B8C0998371; Thu, 5 Jun 2008 19:30:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 960789809F; Thu, 5 Jun 2008 19:30:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4LA9-00004v-GQ; Thu, 05 Jun 2008 15:30:17 -0400 Date: Thu, 05 Jun 2008 19:30:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Another annotation for threads Message-ID: <20080605193017.GF25085@caradoc.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <18483.36546.101715.670386@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18483.36546.101715.670386@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00063.txt.bz2 On Wed, May 21, 2008 at 02:53:54PM +1200, Nick Roberts wrote: > > This is a patch for another annotation, this time for thread changes. It > follows an earlier patch (not committed) for notifying thread changes in MI > using observers. In that patch thread changes were notified in two places: > normal_stop in infrun.c and do_captured_thread_select in thread.c. Here > normal_stop is used but the second call has been moved to thread_command so > that temporary thread changes in commands like "info thread", "-var-update" etc > aren't reported. > > In the doc patch, I've used @r{, annotation} with findex but I don't know what > all this does as annotate.texinfo doesn't appear to have a function index. > > If this patch is OK, I will submit a similar one for MI using an observer. It's quite likely that I've gotten turned around in all the discussion while I was away, and you've already answered this. But here's my question anyway: if there's going to be an observer to do this in MI, why shouldn't annotate.c use the same observer to call annotate_thread_changed? -- Daniel Jacobowitz CodeSourcery