From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26304 invoked by alias); 5 Jun 2008 18:17:02 -0000 Received: (qmail 26284 invoked by uid 22791); 5 Jun 2008 18:17:01 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 18:16:42 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 396A6983F8; Thu, 5 Jun 2008 18:16:40 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 1511F98371; Thu, 5 Jun 2008 18:16:40 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4K0t-0004yj-CS; Thu, 05 Jun 2008 14:16:39 -0400 Date: Thu, 05 Jun 2008 18:17:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org Subject: Re: [patch] Do not add partial_symbol again and again to the list Message-ID: <20080605181639.GC16610@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sourceware.org References: <20080211223056.GA3833@caradoc.them.org> <47B0CF8A.6080306@qnx.com> <20080211225314.GA5832@caradoc.them.org> <47B27EB1.6030606@qnx.com> <20080503205413.GA22704@caradoc.them.org> <481F58ED.5070207@qnx.com> <20080506141754.GA17275@caradoc.them.org> <48209891.3000400@qnx.com> <20080506175636.GA31803@caradoc.them.org> <4820B072.8030906@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4820B072.8030906@qnx.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00046.txt.bz2 On Tue, May 06, 2008 at 03:24:34PM -0400, Aleksandar Ristovski wrote: > Daniel Jacobowitz wrote: >> >> I think we should finish up this patch, and then proceed from there. >> >> Should we use this optimization for all global psymtabs? If so, then >> we ought to do it in common code so that all the other symbol readers, >> like stabs, benefit. >> > > Ok, here is simplified, but with broader consequences patch. > > The patch now affects all readers that use add_psymbol_to_list by not > allowing duplicate partial symbols in the global psymbol list (for a given > objfile). > > Tested on linux dwarf2 format, no regression. I did > not test other debug formats. This is OK if you'll rename bcache_added to deprecated_bcache_added, as we discussed before. I think it'll work fine. > +void * > +bcache_added (const void *addr, int length, struct bcache *bcache, > + int *added) Wrong indentation there? -- Daniel Jacobowitz CodeSourcery