From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22727 invoked by alias); 5 Jun 2008 18:03:56 -0000 Received: (qmail 22673 invoked by uid 22791); 5 Jun 2008 18:03:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 18:03:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A4A17983F8; Thu, 5 Jun 2008 18:03:32 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 556FE98371; Thu, 5 Jun 2008 18:03:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4JoB-0004kx-Ev; Thu, 05 Jun 2008 14:03:31 -0400 Date: Thu, 05 Jun 2008 18:03:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: remove global stop_bpstat dependency from breakpoints module Message-ID: <20080605180331.GB16610@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200805080222.04976.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805080222.04976.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00045.txt.bz2 On Thu, May 08, 2008 at 02:22:04AM +0100, Pedro Alves wrote: > I had missed this on the non-stop series. I'll need to context switch > stop_bpstat in non-stop mode, because there, we'll have simultaneous > independant stop events, one per thread, and each should have its own > stop_bpstat. That's a small change to patch 4 in series I posted. The implementation makes it look like this will work for watchpoints too. If we want to preserve that - which is not the documented behavior - then I agree we should context-switch stop_bpstat. But I'm thinking it makes more sense to restrict this to breakpoints, and search for a breakpoint at the current PC. What do you think? Also, does that remove the only reason to context-switch stop_bpstat? If so, we don't need this patch at all. > One way to fix it, would be to also loop through all threads to update > their version of stop_bpstat, but I'd like better. If we do need to context-switch stop_bpstat, it seems like checking all of those would be simpler than this patch as posted. -- Daniel Jacobowitz CodeSourcery