From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13081 invoked by alias); 5 Jun 2008 17:36:57 -0000 Received: (qmail 13072 invoked by uid 22791); 5 Jun 2008 17:36:57 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 17:36:37 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3727B98371; Thu, 5 Jun 2008 17:36:36 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0DDC59809F; Thu, 5 Jun 2008 17:36:36 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4JO6-0004Og-RF; Thu, 05 Jun 2008 13:36:34 -0400 Date: Thu, 05 Jun 2008 17:36:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] PR gdb/1665 pending catch/throw catchpoints Message-ID: <20080605173634.GA16610@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sources.redhat.com References: <4817E37A.8020705@qnx.com> <20080501201239.GO22218@caradoc.them.org> <481B52B1.2050609@qnx.com> <20080605160543.GC29085@caradoc.them.org> <484816DF.2080005@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <484816DF.2080005@qnx.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00044.txt.bz2 On Thu, Jun 05, 2008 at 12:39:59PM -0400, Aleksandar Ristovski wrote: > Daniel Jacobowitz wrote: >> Did you deliberately replace (exception thrown) with (thrown) >> in your 2008-05-28 patch to print_exception_catchpoint? >> > > No, I'm afraid "exception" part got lost in translation. Sorry about that. Attached is a small patch correcting this. > > Also attached exception.exp diff (cummulative with your diff), all I did was I removed \r\n from the expected output. With the changes, I get 14 passes. > > 2008-06-05 Aleksandar Ristovski > > * breakpoint.c (print_exception_catchpoint): Put 'exception' back to 'exception caught|thrown' message. This is OK, and so is the revised exception.exp patch. Thanks. -- Daniel Jacobowitz CodeSourcery