From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11404 invoked by alias); 29 May 2008 21:33:43 -0000 Received: (qmail 11395 invoked by uid 22791); 29 May 2008 21:33:43 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 29 May 2008 21:33:11 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4TLWA3g281520 for ; Thu, 29 May 2008 21:32:10 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4TLWAps3473626 for ; Thu, 29 May 2008 23:32:10 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4TLW9G4009210 for ; Thu, 29 May 2008 23:32:09 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4TLW9TA009207; Thu, 29 May 2008 23:32:09 +0200 Message-Id: <200805292132.m4TLW9TA009207@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 29 May 2008 23:32:09 +0200 Subject: Re: [RFA/commit] Fix SP register unwinding on alpha-tru64 To: brobecker@adacore.com (Joel Brobecker) Date: Fri, 30 May 2008 15:20:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080529205215.GG13826@adacore.com> from "Joel Brobecker" at May 29, 2008 01:52:15 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00766.txt.bz2 Joel Brobecker wrote: > Index: alpha-tdep.c > =================================================================== > --- alpha-tdep.c (revision 131678) > +++ alpha-tdep.c (working copy) > @@ -1175,6 +1175,10 @@ alpha_heuristic_frame_prev_register (str > struct alpha_heuristic_unwind_cache *info > = alpha_heuristic_frame_unwind_cache (this_frame, this_prologue_cache, 0); > > + /* The stack pointer of the previous frame is this frame's vfp. */ > + if (regnum == ALPHA_SP_REGNUM) > + return frame_unwind_got_constant (this_frame, regnum, info->vfp); > + > /* The PC of the previous frame is stored in the link register of > the current frame. Frob regnum so that we pull the value from > the correct place. */ Hmm, in alpha-mdebug-tdep.c this is now implemented as: /* The stack pointer of the previous frame is computed by popping the current stack frame. */ if (!trad_frame_addr_p (info->saved_regs, ALPHA_SP_REGNUM)) trad_frame_set_value (info->saved_regs, ALPHA_SP_REGNUM, vfp); at the end of alpha_mdebug_frame_unwind_cache ... Should the two files use the same method here? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com