Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Re: longjmp handling vs. glibc LD_POINTER_GUARD 	problems
Date: Thu, 22 May 2008 03:14:00 -0000	[thread overview]
Message-ID: <20080521194357.GA2934@caradoc.them.org> (raw)
In-Reply-To: <200805211920.m4LJKJXS016101@d12av02.megacenter.de.ibm.com>

On Wed, May 21, 2008 at 09:20:19PM +0200, Ulrich Weigand wrote:
> Another issue with your patch is the use of frame_id_inner ... I'd rather
> get rid of this function instead of adding new uses, because this really
> requires that it is possible to compare two stack (frame) addresses 
> along a linear order.  This breaks for me in multi-architecture scenarios,
> but even on existing targets it may not always work OK (e.g. if signal
> handlers run on a different frame, or if the code uses some sort of
> user-level threading or coroutine library ...).  Maybe instead of
> comparing frame_ids, it would be better to check whether or not a
> frame with the given ID still exists in the current backtrace?

Let's be careful, if doing that, that we don't search too far up the
stack chain.  Infinite stacks are a not uncommon failure mode when
something's gone wrong in GDB...

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2008-05-21 19:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-14 18:24 Ulrich Weigand
2008-05-14 19:14 ` Daniel Jacobowitz
2008-05-14 22:01   ` Ulrich Weigand
2008-05-14 19:17 ` Pedro Alves
2008-05-17 14:00   ` Pedro Alves
2008-05-21  4:20     ` [patch] " Pedro Alves
2008-05-22  0:11       ` Ulrich Weigand
2008-05-22  0:14         ` Pedro Alves
2008-05-22 15:20           ` Pedro Alves
2008-05-22 15:34             ` Daniel Jacobowitz
2008-05-22 16:17               ` Pedro Alves
2008-05-22 16:38                 ` Ulrich Weigand
2008-05-22 17:03                   ` [patch] Re: longjmp handling vs. glibc LD_POINTER_GUARD ?problems Daniel Jacobowitz
2008-05-22 16:29           ` [patch] Re: longjmp handling vs. glibc LD_POINTER_GUARD problems Ulrich Weigand
2008-05-22  3:14         ` Daniel Jacobowitz [this message]
2008-05-14 23:03 ` David Miller
2008-05-15  0:39   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521194357.GA2934@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox