Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] update alpha-osf to new value-based unwinding
Date: Wed, 21 May 2008 14:49:00 -0000	[thread overview]
Message-ID: <20080521034230.GC4080@adacore.com> (raw)
In-Reply-To: <200805182011.m4IKBwY3029439@d12av02.megacenter.de.ibm.com>

Hi Ulrich,

> If you have a way of testing on that platform, would you mind
> testing the following patch?  This switches alpha-mdebug-tdep.c
> to use trad-frame instead of relying SIZEOF_FRAME_SAVED_REGS;
> if this is in, we can finally get rid of that macro ...

Nice! Sorry for my late reply, but the machine where I built
everything had a HD failure, and so I had to redo everything
from scratch on another machine. Since our Tru64 machines are
not exactly race cars....

> 	* alpha-mdebug-tdep.c: Include "trad-frame.h".
> 	(struct alpha_mdebug_unwind_cache): Change type of SAVED_REGS to
> 	struct trad_frame_saved_reg *.
> 	(alpha_mdebug_frame_unwind_cache): Allocate SAVED_REGS using
> 	trad_frame_alloc_saved_regs.  Update accesses.  Record previous
> 	value of SP as being vfp.
> 	(alpha_mdebug_frame_prev_register): Use trad_frame_get_prev_register.
> 	* Makefile.in (alpha-mdebug-tdep.o): Update dependencies.

According to our testsuite, there was no regression found.
I think that shows that the changes are sane.

-- 
Joel


  reply	other threads:[~2008-05-21  3:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09  8:18 Joel Brobecker
2008-05-09 12:08 ` Joel Brobecker
2008-05-19 13:27 ` Ulrich Weigand
2008-05-21 14:49   ` Joel Brobecker [this message]
2008-05-21 18:00     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521034230.GC4080@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox