From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2101 invoked by alias); 20 May 2008 15:33:25 -0000 Received: (qmail 2090 invoked by uid 22791); 20 May 2008 15:33:24 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 May 2008 15:33:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 17CF42A992E; Tue, 20 May 2008 11:33:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TXItUE29QufT; Tue, 20 May 2008 11:33:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C975F2A9813; Tue, 20 May 2008 11:33:00 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A7DA8E7ACD; Tue, 20 May 2008 08:32:58 -0700 (PDT) Date: Tue, 20 May 2008 18:09:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] New annotation for threads Message-ID: <20080520153258.GB4669@adacore.com> References: <20080501181758.GD3801@adacore.com> <18458.21177.959458.278174@kahikatea.snap.net.nz> <20080501233703.GF3801@adacore.com> <18458.23326.25887.70597@kahikatea.snap.net.nz> <18478.48682.13900.951343@kahikatea.snap.net.nz> <18479.62120.536436.427524@kahikatea.snap.net.nz> <20080520035226.GA4669@adacore.com> <18482.29129.410026.264704@kahikatea.snap.net.nz> <18482.33700.236263.655308@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18482.33700.236263.655308@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00599.txt.bz2 > > I'll put it inside a function. I don't want to create a separate script > > because I think this test belongs with all the other tests for level 2 > > annotations. > > Like below. That's reasonable. I, on the other hand, prefer having zillions of little scripts rather than one master script, because investigating a failure is often easier. These giant test scripts are a little hard to follow sometimes... > 2008-05-20 Nick Roberts > > * gdb.base/annota1.exp (thread_test): Test for new annotation. OK. Thank you, -- Joel