From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24464 invoked by alias); 20 May 2008 15:21:36 -0000 Received: (qmail 24452 invoked by uid 22791); 20 May 2008 15:21:34 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 May 2008 15:21:07 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4KFL42D236334 for ; Tue, 20 May 2008 15:21:04 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4KFL3vg2592892 for ; Tue, 20 May 2008 17:21:03 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4KFL3Xa007384 for ; Tue, 20 May 2008 17:21:03 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4KFL31Y007381; Tue, 20 May 2008 17:21:03 +0200 Message-Id: <200805201521.m4KFL31Y007381@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 20 May 2008 17:21:03 +0200 Subject: Re: [patch]: Get rid of deprecated_print_address_numeric To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 20 May 2008 17:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <48313ECB.4040105@de.ibm.com> from "Markus Deuling" at May 19, 2008 10:48:11 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00595.txt.bz2 Markus Deuling wrote: > * annotate.c (annotate_source, annotate_frame_begin): Replace > deprecated_print_address_numeric with paddress. > * cli/cli-cmds.c (list_command, edit_command): Likewise. > * tui/tui-stack.c (tui_make_status_line): Likewise. > > * defs.h (deprecated_print_address_numeric): Remove. > * printcmd.c (deprecated_print_address_numeric): Remove. > * maint.c (maint_print_section_info): Fix comment. In general, I like the idea, but I was wondering about one thing: > @@ -418,10 +418,9 @@ annotate_source (char *filename, int lin > else > printf_filtered (("\032\032")); > > - printf_filtered (("%s:%d:%d:%s:0x"), filename, > - line, character, > + printf_filtered (("%s:%d:%d:%s:"), filename, line, character, > mid ? "middle" : "beg"); > - deprecated_print_address_numeric (pc, 0, gdb_stdout); > + fputs_filtered (paddress (pc), gdb_stdout); > printf_filtered (("\n")); Hmm, I guess one of the benefits of paddress is that you no longer need to break out a single (logical) message into multiple pieces. Something like printf_filtered (("%s:%d:%d:%s:%s\n"), filename, line, character, mid ? "middle" : "beg", paddress (pc)); instead of the lines above would be better. (Even if that doesn't really matter in this particular case, in general it is also better to use complete phrases as strings for translation.) Would you mind changing the patch accordingly? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com