Re: [RFC] 09/10 Add "continue --all"

Pedro Alves
2008-05-07T11:36:47Z

A Wednesday 07 May 2008 09:21:53, Pierre Muller wrote:
> I don't claim to understand this patch,
> but I am still curious about one point:
>
> why do you use TARGET_SIGNAL_0
> in proceed_ptid,
> while in non-stop mode, TARGET_SIGNAL_DEFAULT is used.
>

Because I copy&pasted it from somewhere else, and
didn't notice that. :-)

> If I understood correctly the code in
> proceed function from infrun.c,
> this would mean that in the non-stop mode with --all option,
> even if stop_signal was set to a value
> that is registered as "PASS",
> stop_signal would be reset and
> not passed to the inferior.
>
>
> Isn't that a misbehavior?
>

Thanks! That's indeed a bug.

> But anyway, should stop_signal become
> a threadvar, in the sense that it should
> be saved and restore in context_switch?
>

That's right. Not scritly command-per-thread related, but it
was taken care of in patch 4.

--
Pedro Alves