Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Remove addr, endaddr, offset from obj_section
Date: Sat, 17 May 2008 00:11:00 -0000	[thread overview]
Message-ID: <200805161832.m4GIWS30028466@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200805161721.15817.pedro@codesourcery.com> from "Pedro Alves" at May 16, 2008 05:21:15 PM

Pedro Alves wrote:

> I've been meaning to test this on Cygwin/MinGW/Dwarf before
> posting, but since the subject came up, here it goes anyway.

Thanks!

>   I seems the comment is a bit offbase.  The reader still applies
>   ANOFFSET to the symbols, so psymtab->symtab expansion time sees
>   the correct section offsets.  It feels like the xcoff reader 
>   should cope with the section offsets != 0 internally, and not
>   do this ignoring, but since I don't have access to any AIX system, 
>   I didn't investigate that further.  But I do think things should
>   still work as they used to.

I haven't looked into the patch in detail, but just one comment here:
The guard on this block of code is
#ifndef DEPRECATED_IBM6000_TARGET
so it is executed on every target *but* AIX.  Removing it doesn't 
change the behaviour on AIX, so there should be no need to specially
test on AIX.

(In any case, I'll be happy to test patches on AIX if necessary.)


Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-05-16 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16 20:42 Pedro Alves
2008-05-17  0:11 ` Ulrich Weigand [this message]
2008-05-17  2:17   ` Pedro Alves
2008-06-05 19:16 ` Daniel Jacobowitz
2008-08-20 11:23   ` Pedro Alves
2008-08-21 13:28     ` Pedro Alves
2008-09-02  9:33       ` Andreas Schwab
2008-09-02 21:09         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805161832.m4GIWS30028466@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox