From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29512 invoked by alias); 15 May 2008 10:11:39 -0000 Received: (qmail 29491 invoked by uid 22791); 15 May 2008 10:11:38 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 May 2008 10:11:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m4FAB9HU025611 for ; Thu, 15 May 2008 06:11:09 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m4FAB849004281 for ; Thu, 15 May 2008 06:11:09 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m4FAB6OL029310 for ; Thu, 15 May 2008 06:11:07 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.2) with ESMTP id m4FAB44k008105; Thu, 15 May 2008 12:11:04 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m4FAB0pA008101; Thu, 15 May 2008 12:11:00 +0200 Date: Thu, 15 May 2008 16:39:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com, drow@false.org Subject: Re: Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap)) Message-ID: <20080515101100.GA3624@host0.dyn.jankratochvil.net> References: <20080512203232.GA28415@host0.dyn.jankratochvil.net> <200805131700.m4DH0mDf006985@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805131700.m4DH0mDf006985@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00461.txt.bz2 On Tue, 13 May 2008 19:00:48 +0200, Ulrich Weigand wrote: ... > Which parts of GDB do you think do not support overlays? I'd be interested > in fixing such problems ... There is still a lot of stub functions X() just calling X_sect() using find_pc_mapped_section(), these should get removed as otherwise one may find a countercase where it fails for the overlayed sections. [blockvector_for_pc, block_for_pc, find_pc_psymtab, find_pc_psymbol, find_pc_symtab, find_pc_section, find_pc_function] > For now, I'm using the patch below that simply falls back to the non-addrmap > case when debugging overlays and the addrmap returned the wrong section. I started coding a similiar patch as IMO the overlayed sections have no use for addrmap as they are not discontiguous, thanks for fixing it up this way. ... > If there is no objection, I'd like to commit this to fix the present > regression > until we have a proper implementation of addrmaps for the overlay case. It is not worth it as it would mean to either * support multiple results from a single call of addrmap_find() or * to move `addrmap_find' from `struct objfile' to each `struct partial_symtab' which is IMO not worth the performance in a general case as your patch only stays at the same performance as before addrmap for the overlayed case. Regards, Jan