From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14464 invoked by alias); 14 May 2008 19:17:48 -0000 Received: (qmail 14454 invoked by uid 22791); 14 May 2008 19:17:47 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 May 2008 19:17:25 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4EJGZa0526778 for ; Wed, 14 May 2008 19:16:35 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4EJGZqM1372304 for ; Wed, 14 May 2008 21:16:35 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4EJGYWH027949 for ; Wed, 14 May 2008 21:16:34 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4EJGYWd027946; Wed, 14 May 2008 21:16:34 +0200 Message-Id: <200805141916.m4EJGYWd027946@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 14 May 2008 21:16:34 +0200 Subject: Re: [rfc] Remove "function descriptor" handling on ppc32 To: bauerman@br.ibm.com (Thiago Jung Bauermann) Date: Wed, 14 May 2008 23:02:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, drow@false.org In-Reply-To: <1210791686.617.88.camel@localhost.localdomain> from "Thiago Jung Bauermann" at May 14, 2008 04:01:26 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00446.txt.bz2 Thiago Jung Bauermann wrote: > On Wed, 2008-05-14 at 19:31 +0200, Ulrich Weigand wrote: > > Thus, this all appears to be dead code, and I'd prefer to remove it. > > I've tested the patch below with no change in behaviour on powerpc-linux > > and powerpc64-linux. > > > > Am I overlooking anything here? > > By the way, the patch also made bfd_lookup_symbol in solib-svr4.c look > for symbols in data sections, and added a call to > gdbarch_convert_from_func_ptr_addr. Is that dead code as well? No, this is still needed on powerpc64, where the symbols point to the .opd section ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com