Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: davem@davemloft.net
Cc: gdb-patches@sourceware.org, roland@redhat.com
Subject: Re: [PATCH]: Fix syscall restart handling on sparc*-linux
Date: Sun, 11 May 2008 22:11:00 -0000	[thread overview]
Message-ID: <200805112033.m4BKXYXQ010781@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20080511.131850.175173142.davem@davemloft.net> (message from 	David Miller on Sun, 11 May 2008 13:18:50 -0700 (PDT))

> Date: Sun, 11 May 2008 13:18:50 -0700 (PDT)
> From: David Miller <davem@davemloft.net>
> 
> I've just added a change to the Linux kernel so that gdb can cancel
> system call restarting just like powerpc and x86 do under Linux.
> 
> I've done this by adding a piece of software state, a single bit, into
> the processor state register provided to the debugger, that was
> otherwise totally unused before.

Clever!

> The write_pc target method simply clears the bit, which does nothing
> on previous kernels, but cancels syscall restart on newer kernels.
> 
> This fixes 40 or so testsuite failures.
> 
> Ok to commit?

I wouldn't mind a #define for these bits.  Otherwise, it looks fine to me.

> 2008-05-11  David S. Miller  <davem@davemloft.net>
> 
> 	* sparc-linux-tdep.c (sparc_linux_write_pc): New.
> 	(sparc32_linux_init_abi): Register it.
> 	* sparc64-linux-tdep.c (sparc64_linux_write_pc): New.
> 	(sparc64_linux_init_abi): Register it.


  reply	other threads:[~2008-05-11 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-11 22:03 David Miller
2008-05-11 22:11 ` Mark Kettenis [this message]
2008-05-11 22:44   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805112033.m4BKXYXQ010781@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=davem@davemloft.net \
    --cc=gdb-patches@sourceware.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox