Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] control-c handling on Windows...
Date: Sun, 11 May 2008 13:31:00 -0000	[thread overview]
Message-ID: <20080510180010.GF28890@adacore.com> (raw)
In-Reply-To: <20080510153102.GE28890@adacore.com>

> If only I understood signals and terminals better, I would try to
> understand the reason why GDB still gets the SIGINT despite all our
> efforts. But, right now, I'm a little in the dark :(. I know that
> Nicolas Roche, one of the engineers at AdaCore, has spent quite
> a bit of time studying this sort of issues, so I'll see if I can
> nudge him a little out of his busy schedule to share some of the ideas
> he had.

I spoke with Nico a little. He is pretty certain, based on what he read
of the Windows documentation, that we cannot avoid having GDB receive
the SIGINT. Apparently, the console is responsible for sending those
signals, and its behavior cannot be changed.

I wonder if there might be some sort of timing issue that causes
the signal to sometimes be delivered after we stopped ignoring control
events.  In other words, some of the time, we receive the signal
reasonably close to when we receive the debug event for the new thread,
and so it gets ignored.  But some other time, we receive the signal
sufficiently after we got the debug event that we already got out of
get_win32_debug_event and restored the regular SIGINT handler...
That would explain why we're seeing the QUIT message.

So the problem becomes when to handle the signal and when to ignore it.
I'll keep thinking about it for a while, but I haven't found a solution
yet.

On a side note, utils.c:quit is:

    void
    quit (void)
    {
    #ifdef __MSDOS__
      /* No steenking SIGINT will ever be coming our way when the
         program is resumed.  Don't lie.  */
      fatal ("Quit");
    #else
      if (job_control
          /* If there is no terminal switching for this target, then we can't
             possibly get screwed by the lack of job control.  */
          || current_target.to_terminal_ours == NULL)
        fatal ("Quit");
      else
        fatal ("Quit (expect signal SIGINT when the program is resumed)");
    #endif
    }

Not sure when __MSDOS__ is defined, but perhaps we should extend
that case to mingw & cygwin as well? At least we wouldn't get the
"expect signal SIGINT when the program is resumed" part which
I don't think can happen on Windows anymore.

-- 
Joel


  parent reply	other threads:[~2008-05-10 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08  9:46 Joel Brobecker
2008-05-10  4:34 ` Christopher Faylor
2008-05-10 13:10   ` Joel Brobecker
2008-05-10 15:31     ` Christopher Faylor
2008-05-10 22:28       ` Joel Brobecker
2008-05-11  5:30         ` Christopher Faylor
2008-05-11 13:31         ` Joel Brobecker [this message]
2008-05-11 13:46           ` Eli Zaretskii
2008-05-11 13:58           ` Christopher Faylor
2008-05-11 21:26             ` Joel Brobecker
2008-05-17 11:38               ` Christopher Faylor
2008-05-21  0:34                 ` Joel Brobecker
2008-05-21  3:19                   ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080510180010.GF28890@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox