From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9489 invoked by alias); 10 May 2008 14:45:25 -0000 Received: (qmail 9473 invoked by uid 22791); 10 May 2008 14:45:24 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 10 May 2008 14:45:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 64E272A997A; Sat, 10 May 2008 10:45:05 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vfFNv5gqwfNy; Sat, 10 May 2008 10:45:05 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2E6672A997F; Sat, 10 May 2008 10:45:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A3F63E7ACD; Sat, 10 May 2008 07:45:01 -0700 (PDT) Date: Sat, 10 May 2008 22:12:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Report the main thread. Message-ID: <20080510144501.GD28890@adacore.com> References: <18469.39280.284106.858072@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18469.39280.284106.858072@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00340.txt.bz2 > Now that Joel has requested that I use observer_attach_new_thread for > annotations this approach doesn't only produce MI output so it needs to > be conditioned on MI: > > @@ -124,6 +124,10 @@ add_thread_silent (ptid_t ptid) > tp->num = ++highest_thread_num; > tp->next = thread_list; > thread_list = tp; > + > + if (ui_out_is_mi_like_p (uiout)) > + observer_notify_new_thread (tp); > + > return tp; > } I am afraid this is not right. Could you elaborate more on what the problem is? -- Joel