From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26086 invoked by alias); 9 May 2008 19:29:12 -0000 Received: (qmail 26071 invoked by uid 22791); 9 May 2008 19:29:12 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 May 2008 19:28:50 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id m49JSlKX124446 for ; Fri, 9 May 2008 19:28:47 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m49JSl6U3575980 for ; Fri, 9 May 2008 21:28:47 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m49JSlfk018952 for ; Fri, 9 May 2008 21:28:47 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m49JSl0X018948; Fri, 9 May 2008 21:28:47 +0200 Message-Id: <200805091928.m49JSl0X018948@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 9 May 2008 21:28:46 +0200 Subject: Re: [rfc] Retrieve libraries from remote target To: eliz@gnu.org Date: Fri, 09 May 2008 23:58:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Eli Zaretskii" at May 09, 2008 09:45:56 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00326.txt.bz2 Eli Zaretskii wrote: > > Date: Thu, 8 May 2008 22:21:56 +0200 (CEST) > > From: "Ulrich Weigand" > > > > The user interface is simple: if the path specified as "sysroot" starts > > with the string "remote:", the sysroot location is assumed to be on the > > remote target. > > What if my _local_ "sysroot" happens to begin with the literal string > "remote:"? How can I tell GDB this is not a remote location? You cannot. Is this limitation a real problem? > > + error (_("Could not open `%s' as an executable file: %s"), > > + temp_pathname, bfd_errmsg (bfd_get_error ())); > > In other error messages, you used "..", not `..', to quote file names. > I like `..' better, and I think we use `..' in more places than we use > "..". I think consistency is important in user messages. All messages in my patch were just copies from one place to another; but I agree that they should be consistent. I'll change everything to use `..'. > > + if (strlen (bfd_get_filename (abfd)) >= SO_NAME_MAX_PATH_SIZE) > > + error (_("Full path name length of shared library exceeds \ > > +SO_NAME_MAX_PATH_SIZE in so_list structure.")); > > Is this really a useful message, especially since we don't show the > actual value of SO_NAME_MAX_PATH_SIZE and the actual length of the > file name? I say either show the two numbers explicitly, or just tell > it's too long. (Yes, I know you only made a minor modification of an > existing message.) I think just "Shared library file name is too long." or something similar would be enough; the user cannot really do anything in that situation anyway ... > Also, GNU coding standards frown on using "path name", they want us to > use "file name". If you do that, I think you can lose the "Full" > part. OK. > Finally, this needs documentation before it is committed. Sure, I'll add that. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com