A Thursday 08 May 2008 12:42:51, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>
> > Date: Tue, 6 May 2008 16:49:50 +0100
> >
> > +  if (args != NULL)
> > +    {
> > +      if (strncmp (args, "--all", 5) == 0)
>
> Can we please void literal constants like 5 here?  sizeof should be
>
> our friend, and you actually use it 3 lines below this:
> > +	{
> > +	  all_threads = 1;
> > +	  args += sizeof ("--all") - 1;
> > +	  if (*args == '\0')
> > +	    args = NULL;
> > +	}

Oooops!

And after a bit, it hit me that we use /opt most everywhere
else, so "continue /a" makes more sense?

(gdb) help continue
Continue program being debugged, after signal or breakpoint.
If proceeding from breakpoint, a number N may be used as an argument,
which means to set the ignore count of that breakpoint to N - 1 (so that
the breakpoint won't break until the Nth time it is reached).

If non-stop mode is enabled, continue only the current thread,
otherwise all the threads in the program are continued.  To
continue all stopped threads in non-stop mode, use the /a option.
Specifying /a and an ignore count simultaneously is an error.

-- 
Pedro Alves