From: Daniel Jacobowitz <drow@false.org>
To: Kees Cook <kees@outflux.net>
Cc: gdb-patches@sourceware.org
Subject: Re: status of PIE support?
Date: Thu, 08 May 2008 19:00:00 -0000 [thread overview]
Message-ID: <20080508173720.GA26555@caradoc.them.org> (raw)
In-Reply-To: <20080508054526.GG12850@outflux.net>
On Wed, May 07, 2008 at 10:45:26PM -0700, Kees Cook wrote:
> Hello! I'm curious what the current status PIE support is?
No status that I know of. No one has been working on it for FSF GDB.
Jan may know more since he maintains the Red Hat packaging.
> What would be required to get this code in shape for a commit? I'm
> currently fairly unfamiliar with gdb internals, but I'm willing to
> learn. :)
My general rules for reviewing patches are:
- they must conform to GNU style guidelines and include changelogs.
This can be tedious, but is not hard - especially not if your
editor supports GNU coding style :-)
- large patches should be broken into separate logical units where
reasonable (this is always a judgement call)
- the submitter and any authors must have FSF copyright assignment
- the submitter has to be able to justify any line of the patch that
does not make sense to the reviewer
Unfortunately, while that's not quite as strict as "you must
understand every line", it's closely related: the more of it a
reviewer has to go figure out on his own, the more work it is to
review the patch, and the harder it will be to find someone with the
time to do it. A good way to handle bits you don't understand is
to remove them and see what breaks; often this isn't practical,
but when it is it's a sign of good tests :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-05-08 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 16:10 Kees Cook
2008-05-08 19:00 ` Daniel Jacobowitz [this message]
2008-05-08 19:50 ` Kees Cook
2008-05-08 20:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508173720.GA26555@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=kees@outflux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox