Re: [RFC] Entry point update with "run" command

Jan Kratochvil
2008-05-04T14:36:47Z

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Fri, 02 May 2008 17:44:47 +0200, Daniel Jacobowitz wrote:
> On Sat, Apr 26, 2008 at 03:22:25PM +0200, Jan Kratochvil wrote:
> > There is a problem whole EXEC_BFD becomes stale - using the more general
> > attached patch.
>
> Does this work if you just call exec_file_attach instead of
> exec_ops.to_open? The difference is target_preopen which I do not
> believe we want here.

Thanks, it works (I was tryint to use exec_file_command instead before).

> If that works, it's OK to commit.

Committed, no regressions on native x86_64-unknown-linux-gnu.

Regards,
Jan

[-- Attachment #2: bfd-reread.patch --]
[-- Type: text/plain, Size: 992 bytes --]

2008-05-04 Jan Kratochvil <jan.kratochvil@redhat.com>

* symfile.c (reread_symbols): Reload EXEC_BFD on its change.

===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.201
retrieving revision 1.202
diff -u -r1.201 -r1.202
--- src/gdb/symfile.c 2008/05/04 03:45:42 1.201
+++ src/gdb/symfile.c 2008/05/04 14:34:06 1.202
@@ -2331,6 +2331,14 @@
/* We need to do this whenever any symbols go away. */
make_cleanup (clear_symtab_users_cleanup, 0 /*ignore*/);

+ if (exec_bfd != NULL && strcmp (bfd_get_filename (objfile->obfd),
+ bfd_get_filename (exec_bfd)) == 0)
+ {
+ /* Reload EXEC_BFD without asking anything. */
+
+ exec_file_attach (bfd_get_filename (objfile->obfd), 0);
+ }
+
/* Clean up any state BFD has sitting around. We don't need
to close the descriptor but BFD lacks a way of closing the
BFD without closing the descriptor. */