From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4943 invoked by alias); 2 May 2008 15:03:36 -0000 Received: (qmail 4934 invoked by uid 22791); 2 May 2008 15:03:36 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 15:03:16 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5166B983DA; Fri, 2 May 2008 15:03:15 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2CD9C983D6; Fri, 2 May 2008 15:03:15 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jrwn4-0000da-Jq; Fri, 02 May 2008 11:03:14 -0400 Date: Fri, 02 May 2008 15:18:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Remove command_line_handler_continuation. Message-ID: <20080502150314.GL29202@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200804242033.40568.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804242033.40568.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00088.txt.bz2 On Thu, Apr 24, 2008 at 07:33:40PM +0300, Vladimir Prus wrote: > > With my previous patch to move all bpstat_do_actions calls into > event handler, all that command_line_handler_continuation does > is to print timings, if those are enabled. However, those timings > don't make much sense. Timings are good for debugging GDB performance, > and in case of command_line_handler_continuation, the times will report > the time when the application run. > > So, this patch removes that continuation. OK? OK once you and Eli agree about documenting the timings. -- Daniel Jacobowitz CodeSourcery