From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23399 invoked by alias); 2 May 2008 14:36:32 -0000 Received: (qmail 23128 invoked by uid 22791); 2 May 2008 14:36:31 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 14:36:06 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 24A8C983DA; Fri, 2 May 2008 14:36:04 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 005CF983D6; Fri, 2 May 2008 14:36:03 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JrwMl-0000GZ-8W; Fri, 02 May 2008 10:36:03 -0400 Date: Fri, 02 May 2008 14:38:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfa, v2] Fix inferior calls during interrupted system calls on PowerPC Message-ID: <20080502143603.GH29202@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200803271933.m2RJXpRS017283@d12av02.megacenter.de.ibm.com> <200804251425.m3PEPGp6011396@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804251425.m3PEPGp6011396@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00084.txt.bz2 On Fri, Apr 25, 2008 at 04:25:10PM +0200, Ulrich Weigand wrote: > Hello, > > this is an updated version of the patch to fix inferior system > calls during interrupted system calls on PowerPC Linux: > http://sourceware.org/ml/gdb-patches/2008-03/msg00452.html > > Retested on powerpc-linux and powerpc64-linux, both natively and > using a local gdbserver. Fixes all interrupt.exp failures. > > Dan, are the remote/gdbserver parts of this patch OK? You wrote: > gdbserver is switched to always use powerpc-linux32/64 instead > of powerpc-32/64. This still leaves the new registers out on > any non-AltiVec platforms. I guess for powerpc-e500 we could > create a similar powerpc-linuxe500 feature, if this is required. > I'm not sure how to handle the default (non-AltiVec, non-SPE) > case which does not yet use XML. Simply adding registers to > the .dat files is probably not a good idea as it might break > old GDBs that connect to the new gdbserver ... I am not terribly concerned about breaking old GDBs. I think keeping new GDB able to connect to old stubs is important, but if there's a feature to add that means a new stub requires a new GDB that's usually easy to accomodate - host programs are easier to upgrade than target programs. We could switch the default case to use XML-generated data files and add these. I'd like to fix this on SPE too but there's clearly no obligation on you to do that; next time we're working through our GDB test results here at CodeSourcery we'll encounter the failure and hopefully notice and fix it. Unless there's a need to keep the Linux-specific register feature in rs6000-tdep.c, it can go in ppc-linux-tdep.c; see mips-linux-tdep.c's handling of the restart register for an example. Or is it more complicated to get the numbering right that way? -- Daniel Jacobowitz CodeSourcery