From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3473 invoked by alias); 2 May 2008 05:50:55 -0000 Received: (qmail 3464 invoked by uid 22791); 2 May 2008 05:50:55 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 05:50:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BA11D2A96B5; Fri, 2 May 2008 01:50:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B0VyomoWBGmE; Fri, 2 May 2008 01:50:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5D0C62A96B3; Fri, 2 May 2008 01:50:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8100BE7ACD; Thu, 1 May 2008 22:29:49 -0700 (PDT) Date: Fri, 02 May 2008 05:50:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] New annotation for threads Message-ID: <20080502052949.GI3801@adacore.com> References: <18440.29531.916381.569346@kahikatea.snap.net.nz> <20080429023735.GD841@adacore.com> <18454.43094.168458.742737@kahikatea.snap.net.nz> <20080501181758.GD3801@adacore.com> <18458.21177.959458.278174@kahikatea.snap.net.nz> <20080501233703.GF3801@adacore.com> <18458.23326.25887.70597@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18458.23326.25887.70597@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00060.txt.bz2 > 2008-05-02 Nick Roberts > > * annotate.c: Include observer.h. > (annotate_new_thread): New function > (_initialize_annotate): Register it in the new_thread observer. This is pretty good. But because you have added a #include, you need to update the dependencies for annotate.c in Makefile.in: > annotate.o: annotate.c $(defs_h) $(annotate_h) $(value_h) $(target_h) \ > $(gdbtypes_h) $(breakpoint_h) Add: $(annotate_h) at then end of the line. -- Joel