From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24870 invoked by alias); 1 May 2008 20:13:58 -0000 Received: (qmail 24855 invoked by uid 22791); 1 May 2008 20:13:57 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 20:13:40 +0000 Received: (qmail 31833 invoked from network); 1 May 2008 20:13:38 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 May 2008 20:13:38 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: [RFA] Implement thread death notification. Date: Thu, 01 May 2008 20:13:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200804262121.51407.vladimir@codesourcery.com> <20080501200353.GM22218@caradoc.them.org> In-Reply-To: <20080501200353.GM22218@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805020013.33911.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00038.txt.bz2 On Friday 02 May 2008 00:03:53 Daniel Jacobowitz wrote: > On Sat, Apr 26, 2008 at 08:21:50PM +0300, Vladimir Prus wrote: > > > > We now have the 'thread-created' MI notification. This patch adds a > > 'thread-exited' notification to match. Are non-MI bits of this > > patch OK? > > No, I don't think this is good enough. It's "thread has exited but > only if the target is native GNU/Linux". While for some targets we > will not detect thread exit until "info threads", which is > unfortunate, at least the code to call the observer should be in > generic code. Can't we call it from delete_thread? Yes, I think so. OK with that change? > > Also, please do not commit without documentation for the notification. Ehm! The documentation patch is approved last week. - Volodya