From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27965 invoked by alias); 1 May 2008 23:37:26 -0000 Received: (qmail 27953 invoked by uid 22791); 1 May 2008 23:37:26 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 23:37:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8C4322A9669; Thu, 1 May 2008 19:37:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id o5EK8hcZ3Xjt; Thu, 1 May 2008 19:37:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0CAB92A97F4; Thu, 1 May 2008 19:37:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D6C22E7ACD; Thu, 1 May 2008 16:37:03 -0700 (PDT) Date: Thu, 01 May 2008 23:37:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] New annotation for threads Message-ID: <20080501233703.GF3801@adacore.com> References: <18440.29531.916381.569346@kahikatea.snap.net.nz> <20080429023735.GD841@adacore.com> <18454.43094.168458.742737@kahikatea.snap.net.nz> <20080501181758.GD3801@adacore.com> <18458.21177.959458.278174@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18458.21177.959458.278174@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00052.txt.bz2 > > All this can be done inside annotate.c. > > Where in annotate.c? It can't be in _initialize_annotate because that only > gets called at startup and the annotation level can be changed with the > "set annotate" command (which is also why deprecated_delete_breakpoint_hook > and deprecated_modify_breakpoint_hook shouldn't be set there). The printing of the annotation was already guarded by the annotation level. So you can in fact attach the observer from your _initialize procedure, no? -- Joel