From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8061 invoked by alias); 1 May 2008 19:07:40 -0000 Received: (qmail 7982 invoked by uid 22791); 1 May 2008 19:07:40 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 19:07:05 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B9E76983D6; Thu, 1 May 2008 19:07:03 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9C2A798366; Thu, 1 May 2008 19:07:03 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jre7S-0006YB-UC; Thu, 01 May 2008 15:07:02 -0400 Date: Thu, 01 May 2008 19:07:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: GDB Patches Subject: Re: PR 2343 fix: signal number mismatch Message-ID: <20080501190702.GF22218@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , GDB Patches References: <480DEE05.3020505@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480DEE05.3020505@qnx.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00025.txt.bz2 On Tue, Apr 22, 2008 at 09:54:13AM -0400, Aleksandar Ristovski wrote: > Added other changes anyway. The attached patch contains complete proposed > patch. Typically, targets would install their own signal translation > functions during the osabi registration. For gdb configured for the same > host and target, no translation is needed, but for other cases, in general, > it is. > > This patch effectively deprecates functions "target_signal_from_host" and > "target_signal_to_host". Only for targets with cross core file support. Native and remote debugging are not affected. > 2008-04-22 Aleksandar Ristovski > > PR gdb/2343 > * corelow.c (core_open): Use gdbarch_target_signal_from_host to > translate signal numeric value from the target to GDB's enum > target_signal. > * gdbarch.c (gdbarch_target_signal_from_host, > gdbarch_target_signal_to_host, set_gdbarch_target_signal_from_host, > set_gdbarch_target_signal_to_host): New functions. Generated by > gdbarch.sh. > * gdbarch.h: Likewise. > * gdbarch.sh: Added two new functions target_signal_from_host and > target_signal_to_host. > * target.h (default_target_signal_from_host, > default_target_signal_to_host): New functions - declarations. > * signals/signals.c (struct gdbarch): New declaration. > (default_target_signal_to_host, default_target_signal_from_host): > New > functions. Thanks, this is OK. You can just write: * gdbarch.c, gdbarch.sh: Regenerated. for those two files. -- Daniel Jacobowitz CodeSourcery