From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7681 invoked by alias); 30 Apr 2008 13:11:53 -0000 Received: (qmail 7669 invoked by uid 22791); 30 Apr 2008 13:11:52 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Apr 2008 13:11:34 +0000 Received: (qmail 16714 invoked from network); 30 Apr 2008 13:11:31 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Apr 2008 13:11:31 -0000 From: Pedro Alves To: luisgpm@linux.vnet.ibm.com Subject: Re: Handle DW_AT_const_value/DW_FORM_strp variables Date: Wed, 30 Apr 2008 14:12:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org, Joel Brobecker References: <200804251915.27580.pedro@codesourcery.com> <200804251959.51368.pedro@codesourcery.com> <1209559400.7131.4.camel@gargoyle> In-Reply-To: <1209559400.7131.4.camel@gargoyle> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_CAHGIzchrX8t7SI" Message-Id: <200804301411.30188.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00697.txt.bz2 --Boundary-00=_CAHGIzchrX8t7SI Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 578 A Wednesday 30 April 2008 13:43:19, Luis Machado wrote: > Pedro, > > This doesn't work as is on PPC. The ".value" pseudo-op it not available, > but using ".short" instead does the trick. Tested on x86 and PPC with > ".short" for the DWARF version field. > > Ok to change this? Eh, oh well, sorry for that. We should change the .long's to explicit .4byte's and .value's to .2byte's as has been done to the other dwarf tests. Find replace is faster than another mail roundtrip, so I went ahead. Tested on x86_64-unknown-linux-gnu and x86-pc-linux-gnu. OK ? -- Pedro Alves --Boundary-00=_CAHGIzchrX8t7SI Content-Type: text/x-diff; charset="utf-8"; name="fix_const_strp.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_const_strp.diff" Content-length: 2560 2008-04-30 Pedro Alves * gdb.dwarf2/dw2-strp.S: Replace .long by .4byte and .value by .2byte. --- gdb/testsuite/gdb.dwarf2/dw2-strp.S | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) Index: src/gdb/testsuite/gdb.dwarf2/dw2-strp.S =================================================================== --- src.orig/gdb/testsuite/gdb.dwarf2/dw2-strp.S 2008-04-30 13:51:29.000000000 +0100 +++ src/gdb/testsuite/gdb.dwarf2/dw2-strp.S 2008-04-30 13:53:08.000000000 +0100 @@ -19,47 +19,47 @@ .section .debug_info .Lcu1_begin: - .long .Lcu1_end - .Lcu1_start /* Length of Compilation Unit */ + .4byte .Lcu1_end - .Lcu1_start /* Length of Compilation Unit */ .Lcu1_start: - .value 2 /* DWARF version number */ - .long .Ldebug_abbrev0 /* Offset Into Abbrev. Section */ + .2byte 2 /* DWARF version number */ + .4byte .Ldebug_abbrev0 /* Offset Into Abbrev. Section */ .byte 4 /* Pointer Size (in bytes) */ /* CU die */ .uleb128 1 /* Abbrev: DW_TAG_compile_unit */ - .long .Lproducer /* DW_AT_producer */ + .4byte .Lproducer /* DW_AT_producer */ .byte 1 /* DW_AT_language (C) */ .Larray_type: .uleb128 2 /* Abbrev: DW_TAG_array_type */ - .long .Lchar_type-.Lcu1_begin /* DW_AT_type */ + .4byte .Lchar_type-.Lcu1_begin /* DW_AT_type */ .uleb128 3 /* Abbrev: DW_TAG_subrange_type */ - .long .Luint_type-.Lcu1_begin /* DW_AT_type */ + .4byte .Luint_type-.Lcu1_begin /* DW_AT_type */ .byte 0xd /* DW_AT_upper_bound */ .byte 0 /* End of children of die */ .Luint_type: .uleb128 4 /* Abbrev: DW_TAG_base_type */ - .long .Luint_str /* DW_AT_name */ + .4byte .Luint_str /* DW_AT_name */ .byte 4 /* DW_AT_byte_size */ .byte 7 /* DW_AT_encoding */ .Lchar_type: .uleb128 4 /* Abbrev: DW_TAG_base_type */ - .long .Lchar_str /* DW_AT_name */ + .4byte .Lchar_str /* DW_AT_name */ .byte 1 /* DW_AT_byte_size */ .byte 6 /* DW_AT_encoding */ .uleb128 5 /* Abbrev: DW_TAG_variable */ - .long .Lvarname /* DW_AT_name */ - .long .Lconst_type-.Lcu1_begin/* DW_AT_type */ - .long .Lvarcontents /* DW_AT_const_value */ + .4byte .Lvarname /* DW_AT_name */ + .4byte .Lconst_type-.Lcu1_begin/* DW_AT_type */ + .4byte .Lvarcontents /* DW_AT_const_value */ .byte 1 /* DW_AT_external */ .Lconst_type: .uleb128 6 /* Abbrev: DW_TAG_const_type */ - .long .Larray_type-.Lcu1_begin/* DW_AT_type */ + .4byte .Larray_type-.Lcu1_begin/* DW_AT_type */ .byte 0 /* End of children of CU */ .Lcu1_end: --Boundary-00=_CAHGIzchrX8t7SI--