From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/RFC/sparc32] SIGSEGV during fun call when no debugging info
Date: Tue, 29 Apr 2008 15:58:00 -0000 [thread overview]
Message-ID: <200804290802.m3T82Nal006332@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20080429034705.GG16574@adacore.com> (message from Joel Brobecker on Mon, 28 Apr 2008 20:47:05 -0700)
> Date: Mon, 28 Apr 2008 20:47:05 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> One approach would be to enhance the code above to also handle function
> calls when no symbol is found. This is what find_function_in_inferior
> does, and we could do something similar. But seems a bit absurd to do
> that, because we don't have multiple calling conventions on sparc.
> So finding the type would be useless.
Makes sense to me.
> 2008-04-29 Joel Brobecker <brobecker@adacore.com>
>
> * gdbarch.sh: Document the return_value method. Explain that
> the FUNCTYPE parameter might be NULL.
> * gdbarch.h: Regenerated.
> * sparc-tdep.c (sparc32_push_dummy_code): Do not pass the function
> type when calling using_struct_return, as this is unnecessary
> on this target.
>
> Tested on sparc-solaris. Fixes many many regressions in gdb.ada,
> gdb.base and gdb.gdb.
>
> OK to apply?
sure
next prev parent reply other threads:[~2008-04-29 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 8:04 Joel Brobecker
2008-04-29 15:58 ` Corinna Vinschen
2008-04-29 15:58 ` Mark Kettenis [this message]
2008-04-29 18:21 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804290802.m3T82Nal006332@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox