From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27216 invoked by alias); 23 Apr 2008 05:33:31 -0000 Received: (qmail 27200 invoked by uid 22791); 23 Apr 2008 05:33:31 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Apr 2008 05:33:06 +0000 Received: (qmail 2209 invoked from network); 23 Apr 2008 05:33:05 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Apr 2008 05:33:05 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [PATCH] -stack-info-frame/-stack-list-frames Date: Wed, 23 Apr 2008 06:16:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <18446.45778.889114.789630@kahikatea.snap.net.nz> <18446.49934.972945.419064@kahikatea.snap.net.nz> In-Reply-To: <18446.49934.972945.419064@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804230933.04964.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00499.txt.bz2 On Wednesday 23 April 2008 09:03:10 Nick Roberts wrote: > > > Here's a patch to add the frame address to the output of -stack-info-frame > > > and -stack-list-frames and async output when execution stops. It also > > > outputs the source language for -stack-info-frame, these change making it > > > more like "info frame": > > > > Could you first clarify that is the purpose of said fields -- especially > > frame address? > > The frame address is probably of more interest than the pc address, at least > for frames other than the current one. If the call stack includes the frame > address for each frame and the watch window gives the variable's address > then it is possible to infer to which frame that variable belongs. What do you mean by "watch window" here, and how the information about frame a variable belongs to is useful? > In any > case, the extra field comes at almost no cost and a frontend can choose to > ignore it. I supposed you don't plan to write documentation that say "these fields are just in case you need them, feel free to ignore"? I'm trying to understand what is *your* intended use of this information, so that I can make up my mind as to best way to do that. We talked about frame ids before, I think Dan prefers frame ids, if exposed, to be totally opaque. You appear to suggest some smart uses of frame addresses, on the other hand, and I don't understand exactly what uses. - Volodya